This repository was archived by the owner on May 18, 2026. It is now read-only.
fix: not add maven type on params if null or empty#279
Merged
shashwathi merged 3 commits intoAug 23, 2022
Conversation
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
shashwathi
suggested changes
Aug 23, 2022
Contributor
shashwathi
left a comment
shashwathi
left a comment
There was a problem hiding this comment.
Update type field with json tag json:"type,omitempty" to not print the field.
Use the existing MavenSource Type for this change and remove ToSource() func
added 2 commits
August 23, 2022 16:04
This reverts commit 5716ccb.
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
shashwathi
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
When creating a workload with maven flags, the
typewas added asnullif not provided, this PR solves that by having an different struct with type so it is not added to params if not presentWhich issue(s) this PR fixes
Fixes #276
Describe testing done for PR
Local install of cli plugin agains GKE cluster with TAP 1.2
Additional information or special notes for your reviewer