This repository was archived by the owner on May 18, 2026. It is now read-only.
Adds Emojis to the workload get output#280
Merged
Merged
Conversation
shaheerkootteeri
changed the title
odinnordico
reviewed
Aug 24, 2022
odinnordico
reviewed
Aug 24, 2022
odinnordico
reviewed
Aug 24, 2022
Contributor
Author
|
|
Contributor
Author
|
|
shaheerkootteeri
force-pushed
the
iss262
branch
from
807729f to
4d88e94
Compare
shaheerkootteeri
force-pushed
the
iss262
branch
2 times, most recently
from
efcc60f to
1d5f38c
Compare
shashwathi
suggested changes
Aug 30, 2022
shashwathi
reviewed
Aug 30, 2022
shaheerkootteeri
force-pushed
the
iss262
branch
from
5330bec to
fda6812
Compare
shashwathi
reviewed
Aug 30, 2022
Contributor
shashwathi
left a comment
shashwathi
left a comment
There was a problem hiding this comment.
Resolve conflicts and couple of minor comments
shaheerkootteeri
force-pushed
the
iss262
branch
2 times, most recently
from
0397c4a to
ce285e1
Compare
shaheerkootteeri
force-pushed
the
iss262
branch
from
ce285e1 to
299f6de
Compare
shashwathi
approved these changes
Aug 30, 2022
warango4
reviewed
Sep 1, 2022
| Canoe Icon = '🛶' | ||
| Inbox Icon = '📥' | ||
| Question Icon = '❓' | ||
| ThumpsUp Icon = '👍' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
PR adds emojis to the workload get output command
Which issue(s) this PR fixes
Fixes #262
Describe testing done for PR
Added unit test cases with Emojis. Modified integration test to validate the emojis in the output. tested in local cluster.
Additional information or special notes for your reviewer