This repository was archived by the owner on May 18, 2026. It is now read-only.
fix: validate namespace when validating workload#294
Merged
shashwathi merged 1 commit intoAug 30, 2022
Merged
Conversation
shashwathi
suggested changes
Aug 25, 2022
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
odinnordico
force-pushed
the
issue-271-image-upload-no-namespace
branch
from
d7a9552 to
7c7060b
Compare
shashwathi
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Validates if the provided namespace can be accessed by the user when validating if workload exists.
Which issue(s) this PR fixes
Fixes #271
Describe testing done for PR
Loca installation of plugin against TAP1.2 cluster in GKE
Try to create a workload from source code in the default namespace and a non-existing namespace.
Additional information or special notes for your reviewer
This validation applies to all the
apply/createsubcommands, if the namespace does not exist or is not accessible for the user it will throw an error