This repository was archived by the owner on May 18, 2026. It is now read-only.
fix: Adds additional validation for source comparison#311
Merged
Conversation
shashwathi
suggested changes
Sep 1, 2022
Contributor
shashwathi
left a comment
shashwathi
left a comment
There was a problem hiding this comment.
Thanks for identifying the bug and fixing it right away
can you add a test at apply_test.go level with source change?
shaheerkootteeri
force-pushed
the
iss310
branch
from
5d67114 to
48a534d
Compare
shashwathi
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
PR adds additional validations for comparing sources from current workload to new workload
Which issue(s) this PR fixes
Fixes #310
Describe testing done for PR
Added additional unit test cases
Tested in local cluster
Additional information or special notes for your reviewer