This repository was archived by the owner on May 18, 2026. It is now read-only.
Fixes file path issue in client test file for windows#331
Merged
Conversation
warango4
reviewed
Sep 21, 2022
Contributor
warango4
left a comment
warango4
left a comment
There was a problem hiding this comment.
According to your changes, I assume that it was failing because paths were hard-coded and Windows separator is different, right?
shashwathi
reviewed
Sep 21, 2022
shaheerkootteeri
force-pushed
the
iss330
branch
from
92415f0 to
ed5d8b9
Compare
shashwathi
reviewed
Sep 21, 2022
shaheerkootteeri
force-pushed
the
iss330
branch
from
ed5d8b9 to
956a4a4
Compare
shashwathi
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
PR fixes client and config package test cases to support all OS file paths.
Which issue(s) this PR fixes
Fixes #330
Describe testing done for PR
Reran all the unit test cases in Mac as well as windows OS, also ran make commands to install successfully.
Additional information or special notes for your reviewer