This repository was archived by the owner on May 18, 2026. It is now read-only.
fixes test cases that are failing in windows for archive file#335
Merged
Conversation
shashwathi
reviewed
Sep 23, 2022
shaheerkootteeri
force-pushed
the
iss334
branch
from
4c30961 to
c2c4002
Compare
shaheerkootteeri
force-pushed
the
iss334
branch
from
c2c4002 to
956c044
Compare
warango4
approved these changes
Sep 27, 2022
odinnordico
approved these changes
Sep 27, 2022
shashwathi
reviewed
Sep 27, 2022
shaheerkootteeri
force-pushed
the
iss334
branch
from
956c044 to
81cdf17
Compare
shashwathi
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
PR fixes test cases that are failing in windows for archive file due the line break differences in different oS.
Which issue(s) this PR fixes
Fixes #334
Describe testing done for PR
Validated executing unit test cases in mac as well as windows OS, also installing them.
Additional information or special notes for your reviewer