This repository was archived by the owner on May 18, 2026. It is now read-only.
fixes unit test failure for publish local path on windows#350
Merged
Conversation
shashwathi
reviewed
Sep 23, 2022
shaheerkootteeri
force-pushed
the
iss349
branch
3 times, most recently
from
8dcf6b5 to
2d22157
Compare
odinnordico
suggested changes
Sep 29, 2022
shashwathi
reviewed
Sep 29, 2022
Contributor
shashwathi
left a comment
shashwathi
left a comment
There was a problem hiding this comment.
this PR is doing 2 things
- updating hard coded file paths to using filepath lib
- adding test (that gets skipped in windows)
I recommend keeping the goal of a PR to one item. Easy to review and revert.
shaheerkootteeri
force-pushed
the
iss349
branch
from
2d22157 to
516b65d
Compare
odinnordico
previously approved these changes
Sep 30, 2022
shaheerkootteeri
force-pushed
the
iss349
branch
from
516b65d to
570ffed
Compare
shaheerkootteeri
force-pushed
the
iss349
branch
from
570ffed to
1963016
Compare
shashwathi
approved these changes
Oct 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
PR fixes unit test failure for publish local path on windows. the img manifest is showing different in windows and mac when publishing local source with excluded files.
Which issue(s) this PR fixes
Fixes #349
Describe testing done for PR
Unit tests validated in mac as well as windows.
Additional information or special notes for your reviewer