Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Do not print emojis when no color is set#362

Merged
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue301-fixed
Oct 5, 2022
Merged

Do not print emojis when no color is set#362
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue301-fixed

Conversation

@warango4
Copy link
Copy Markdown
Contributor

@warango4 warango4 commented Oct 4, 2022

Pull request

What this PR does / why we need it

Do not print emojis when using --no-color flag with workload get

Which issue(s) this PR fixes

Fixes #301

Describe testing done for PR

  • Added unit testing
  • Added e2e tests

Additional information or special notes for your reviewer

Refer to #314 for more info

Signed-off-by: Wendy Arango warango@vmware.com

Signed-off-by: Wendy Arango <warango@vmware.com>
Comment thread docs/command-reference/tanzu_apps_workload_create.md
Comment thread testing/suite/command_line.go
@shashwathi shashwathi merged commit 75ff77f into vmware-tanzu:main Oct 5, 2022
@warango4 warango4 deleted the issue301-fixed branch October 5, 2022 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--no-color flag or envar also removes emojis

4 participants