Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

feat: Add emojis to workload create/apply/delete#367

Merged
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue263
Oct 11, 2022
Merged

feat: Add emojis to workload create/apply/delete#367
shashwathi merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue263

Conversation

@warango4
Copy link
Copy Markdown
Contributor

@warango4 warango4 commented Oct 6, 2022

Pull request

What this PR does / why we need it

Add emojis to visual feedback for workload create/update/apply and delete

Which issue(s) this PR fixes

Fixes #263

Describe testing done for PR

  • Updated unit testing
  • Added new e2e tests

Additional information or special notes for your reviewer

Signed-off-by: Wendy Arango warango@vmware.com

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

image

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

image

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

image

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

image

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

image

@warango4
Copy link
Copy Markdown
Contributor Author

warango4 commented Oct 6, 2022

USING --no-color FLAG

image

@warango4 warango4 marked this pull request as ready for review October 6, 2022 16:40
odinnordico
odinnordico previously approved these changes Oct 6, 2022
Comment thread testing/e2e/workload_test.go Outdated
Comment thread testing/e2e/workload_test.go Outdated
@danfein
Copy link
Copy Markdown

danfein commented Oct 6, 2022

The UI lgtm, thanks @warango4 !

Comment thread pkg/commands/workload_create_test.go
Comment thread pkg/commands/workload_delete_test.go
Comment thread pkg/commands/workload_update.go Outdated
Comment thread testing/e2e/workload_test.go Outdated
Comment thread testing/e2e/workload_test.go Outdated
Comment thread testing/e2e/workload_test.go Outdated
Comment thread testing/e2e/workload_test.go Outdated
@shaheerkootteeri shaheerkootteeri self-requested a review October 7, 2022 15:21
Comment thread testing/e2e/workload_test.go Outdated
Comment thread pkg/commands/workload.go Outdated
Signed-off-by: Wendy Arango <warango@vmware.com>
@shashwathi shashwathi merged commit 1a1eade into vmware-tanzu:main Oct 11, 2022
@warango4 warango4 deleted the issue263 branch October 11, 2022 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decorate workload create / apply / update feedback

6 participants