This repository was archived by the owner on May 18, 2026. It is now read-only.
Add support for subPath for source #65
Merged
Merged
Conversation
shashwathi
commented
Apr 7, 2022
scothis
reviewed
Apr 7, 2022
Comment on lines
+160
to
+162
| if opts.SubPath != "" && len(source) != 1 { | ||
| errs = errs.Also(validation.ErrDisallowedFields(flags.SubPathFlagName, "subPath flag cannot be used without local-path/git-* sources")) | ||
| } |
Contributor
There was a problem hiding this comment.
This check needs to be lazy. It should be valid to specify --subpath for an update when there is already source defined, or for a create with a file where the workload already has source defined.
rashedkvm
suggested changes
Apr 7, 2022
shashwathi
changed the title
- update subPath when it is empty. this will allow users to unset the field
scothis
reviewed
Apr 8, 2022
- Update subPath only when its changed.
Contributor
Author
|
@rashedkvm @scothis : Ready for another review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds support for subPath field for sources
Which issue(s) this PR fixes
Fixes #35