Skip to content
This repository was archived by the owner on May 18, 2026. It is now read-only.

Adding source info from workload spec to workload get command#74

Merged
rashedkvm merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue21
Apr 13, 2022
Merged

Adding source info from workload spec to workload get command#74
rashedkvm merged 1 commit into
vmware-tanzu:mainfrom
warango4:issue21

Conversation

@warango4
Copy link
Copy Markdown
Contributor

@warango4 warango4 commented Apr 12, 2022

Pull request

What this PR does / why we need it

Add source info when retrieving a workload with apps workload get command. In this PR, sub-path is also added to displayed output

Which issue(s) this PR fixes

Fixes #10
Fixes #21

Describe testing done for PR

Additional information or special notes for your reviewer

Signed-off by: Wendy Arango warango@vmware.com

Comment thread pkg/commands/workload_get.go
Comment thread pkg/commands/workload_get_test.go
Comment thread pkg/printer/workload_source_printer.go Outdated
…utput

For worklad get command, source info is being added to displayed output. This info comes from the supplied specifications for workload.
- Added new file workload_source_printer.go to add source info to command depending on the way the workload was created.
- workload_get.go carries the responsibility deciding which is the info to be displayed.
- Added new test to workload_get_test.go to check the accuracy of the source info being displayed.
Copy link
Copy Markdown
Member

@rashedkvm rashedkvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rashedkvm rashedkvm merged commit 207cc4f into vmware-tanzu:main Apr 13, 2022
@warango4 warango4 deleted the issue21 branch July 14, 2022 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add source information to workload get output Display sub-path in workload get output

5 participants