Skip to content

improve locale utility to fix #1691 and #1694#1699

Merged
Xiaochao8 merged 9 commits intovmware:g11n-ruby-clientfrom
Xiaochao8:g11n-ruby-client-locale-match
May 20, 2022
Merged

improve locale utility to fix #1691 and #1694#1699
Xiaochao8 merged 9 commits intovmware:g11n-ruby-clientfrom
Xiaochao8:g11n-ruby-client-locale-match

Conversation

@Xiaochao8
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1699 (2f9deff) into g11n-ruby-client (c2c5c20) will decrease coverage by 9.79%.
The diff coverage is 35.10%.

@@                 Coverage Diff                  @@
##           g11n-ruby-client    #1699      +/-   ##
====================================================
- Coverage             73.33%   63.54%   -9.80%     
====================================================
  Files                    10       14       +4     
  Lines                   180      288     +108     
====================================================
+ Hits                    132      183      +51     
- Misses                   48      105      +57     
Flag Coverage Δ
coverage 63.54% <35.10%> (-9.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/sgtn-client/cldr/localized_str.rb 100.00% <ø> (ø)
lib/sgtn-client/util/validate-util.rb 76.47% <ø> (+1.47%) ⬆️
lib/sgtn-client/api/translation.rb 26.98% <25.80%> (ø)
lib/sgtn-client/core/config.rb 61.79% <31.81%> (-9.85%) ⬇️
lib/sgtn-client/exceptions.rb 100.00% <100.00%> (ø)
lib/sgtn-client/sgtn-client.rb 83.67% <100.00%> (ø)
lib/singleton-client.rb 100.00% <100.00%> (ø)
lib/singleton-ruby.rb 100.00% <100.00%> (ø)
lib/sgtn-client/core/exceptions.rb
lib/sgtn-client/core/logging.rb 64.70% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a22fc...2f9deff. Read the comment docs.

@Xiaochao8 Xiaochao8 merged commit 212c151 into vmware:g11n-ruby-client May 20, 2022
@Xiaochao8 Xiaochao8 deleted the g11n-ruby-client-locale-match branch May 20, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants