Merged
Conversation
cmd/vserver registered via cli.RegisterService(VServerCmd) but was never imported, so `grn vserver` did not appear. Uncomment the blank import so the package init() runs and the service mounts. Verified: `grn --help` now lists `vserver`; `grn vserver --help` shows all 8 subcommands; full test suite passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
✅ Blocker resolved in Verified on this branch:
Remaining (non-blocking): add |
Route reviews of cmd/vserver, internal/vserverclient, and docs/commands/vserver to the vserver team. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
go test on macos-latest with Go 1.22 aborted with "missing LC_UUID load command": the internal linker omits LC_UUID and recent macOS dyld rejects such binaries. Build/run (CGO_ENABLED=0) is unaffected; only test binaries crash. Run tests with CGO_ENABLED=1 -ldflags=-linkmode=external (system cc is present on ubuntu and macos runners). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the vServer product CLI under
cmd/vserver/following the multi-product architecture:vpc,subnet,secgroup,volume,volumetype,flavor,image,servercommand groups, plus aninternal/vserverclientpackage (zones, completion helpers), formatter/client additions, and mkdocs nav. ~73 files.The vServer CLI does not mount:
cmd/vserver/vserver.gocallscli.RegisterService(VServerCmd)correctly, butcmd/register.gostill has the blank-import commented out:// _ "github.com/vngcloud/greennode-cli/cmd/vserver"Verified by building this branch:
grn --helpshows onlyvks, notvserver. Per the Architecture guide, the one required wiring edit is to uncomment that line incmd/register.go. Until then the entire vserver tree is dead code.Test plan
cmd/vserverblank-import incmd/register.gocd go && CGO_ENABLED=0 go build -o grn .thengrn vserver --helplists the subcommandsgo test ./...(note macOS 26 + Go 1.22 needsCGO_ENABLED=1 go test -ldflags='-linkmode=external' ./...)grn vserver vpc list,volumetype list, etc. against a real project/go/cmd/vserver/ownership🤖 Generated with Claude Code