fix(vks): drop stale --image-id, add --os (align with latest API)#18
Merged
Conversation
…dd --os) The latest VKS API removed imageId from CreateNodeGroupDto/UpdateNodeGroupDto and the cluster create node group. The CLI still required --image-id and sent imageId, which is stale (update-nodegroup even forced a field the API ignores). - create-nodegroup, create-cluster: remove --image-id; add optional --os (ubuntu|linux, default ubuntu) sent as the `os` field - update-nodegroup: remove --image-id entirely; require at least one update field - completion: drop dead image-id completer (/node-group-images); add --os values - docs: replace image-id with --os (creates) / remove (update); fix examples BREAKING: --image-id is no longer accepted on these commands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field-level audit against the latest
vks.jsonfound thatimageIdwas removed from the API's node group DTOs, but the CLI still required--image-idand sentimageId. Fixes the drift:--image-id; add optional--os(ubuntu|linux, defaultubuntu), sent as theosfield perCreateNodeGroupDto.--image-identirely (UpdateNodeGroupDtohas no image field); now requires at least one real update field.--image-idcompleter (/node-group-images); add--osvalue completion (ubuntu/linux). (Note: there was nolist-nodegroup-imagescommand — only this completer.)--image-idwith--oson the create pages, remove it from update-nodegroup, fix usage examples. Zeroimage-idreferences remain.update-clusterwas already in sync — no change.--image-idis no longer accepted oncreate-cluster,create-nodegroup,update-nodegroup. Use--osfor node group image selection.Test plan
go build+go vetcleango test ./...— all passgrn vks create-nodegroup/create-cluster --helpshow--os(default ubuntu), no--image-idgrn vks update-nodegroup --helphas no--image-idgrn __complete vks create-nodegroup --os ""→ubuntu,linux🤖 Generated with Claude Code