feat(vks): flag revamp (enabled/disabled toggles, TIGERA, os rocky) + drop get-nodegroup-events#19
Merged
Merged
Conversation
- remove get-nodegroup-events command (+ docs/nav) - network-type: CALICO -> TIGERA (help, completion, cidr validation) - --os: add rocky (ubuntu, linux, rocky) - replace boolean toggle flags with explicit enabled|disabled string flags: create-cluster: --private-cluster, --private-nodes, --load-balancer-plugin, --block-store-csi-plugin; create-nodegroup: --private-nodes; update-cluster: --load-balancer-plugin/--block-store-csi-plugin (unset=unchanged) via a shared parseToggle helper (rejects invalid values) - completion + docs updated; changelog (api-change) BREAKING: --enable-private-cluster/--enable-private-nodes/--no-*-plugin and update-cluster's --enabled-*/--no-* flags are replaced; CALICO no longer accepted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
config.LoadConfig returns (nil, err) when the profile is absent from the credentials file; runConfigure ignored the error and dereferenced nil at configure.go:47. Guard for err/nil and start from empty defaults so `grn configure --profile <new>` creates the profile instead of crashing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Added a bonus bugfix in Root cause: Verified: |
Nested group commands (grn vks, grn vserver and its sub-groups) used Run: cmd.Help() with cobra's default arg handling, which (unlike the root) does not reject unknown subcommands — so `grn vks foobar` printed help and exited 0. Add Args: cobra.NoArgs to every group command so an unknown subcommand yields an "unknown command" error and a non-zero exit, while bare invocation still shows help. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-nodegroup-eventscommand (file, registration, docs, nav, README).CALICO→TIGERAin--help, completion, and the--cidr-required validation (API accepts TIGERA, not CALICO).--os: addrocky→ubuntu, linux, rocky(defaultubuntu).<enabled|disabled>(via a sharedparseTogglehelper that rejects invalid values):--private-cluster(default disabled),--private-nodes(disabled),--load-balancer-plugin(enabled),--block-store-csi-plugin(enabled)--private-nodes(disabled)--load-balancer-plugin/--block-store-csi-plugin(unset = unchanged) — replaces the old--enabled-*/--no-*pairs(Task "get-versions" dropped —
list-cluster-versionsalready covers it.)Old flags removed:
--enable-private-cluster,--enable-private-nodes,--no-load-balancer-plugin,--no-block-store-csi-plugin(create-cluster);--enable-private-nodes(create-nodegroup);--enabled-*/--no-*plugin flags (update-cluster).CALICOno longer accepted for--network-type.get-nodegroup-eventsremoved.Test plan
go test ./...pass--helpshows new flags + defaults;get-nodegroup-eventsgone--private-cluster bogus→ clear error)--os→ ubuntu/linux/rocky;--network-type→ TIGERA/...; toggles → enabled/disabled🤖 Generated with Claude Code