feat(vks): create-cluster provisions control plane only (drop node group)#28
Merged
Merged
Conversation
…oup) create-cluster no longer builds a default node group. Removed all node-group flags (--node-group-name, --flavor-id, --os, --disk-type, --ssh-key-id, --disk-size, --num-nodes, --private-nodes, --security-groups, --labels, --taints) and the nodeGroups field from the request body; dry-run validation drops the node-group checks. Users create workers separately with 'grn vks create-nodegroup'. Note: the VKS API spec still lists nodeGroups as required; this aligns the CLI ahead of a spec update that makes it optional. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-clusternow creates only the cluster (control plane). It no longer builds a default node group in the same call. Users add workers separately withgrn vks create-nodegroup.Changes
--node-group-name,--flavor-id,--os,--disk-type,--ssh-key-id,--disk-size,--num-nodes,--private-nodes,--security-groups,--labels,--taints.nodeGroupsfrom the request body.--name,--k8s-version,--network-type,--vpc-id,--subnet-id(required);--cidr,--description,--private-cluster,--release-channel,--load-balancer-plugin,--block-store-csi-plugin,--dry-run.Longhelp + docs now point tocreate-nodegroupfor adding workers.This removes flags and changes the request body, so it's breaking for anyone scripting
create-clusterwith node-group flags. ThenodeGroupsfield is currently still listed as required in the VKS API spec — this PR aligns the CLI ahead of a spec update (per request) that makesnodeGroupsoptional. Until the spec/server is updated, a real create call may be rejected server-side;--dry-runworks offline.Testing
go vet ./...clean; fullgo test ./...passes; build clean.--helpshows only cluster flags;--dry-runvalidates a control-plane-only cluster successfully.🤖 Generated with Claude Code