Skip to content

fix(terraform-ls): add missing skill name field and migrate to subdirectory format v1.0.1#14

Merged
vnz merged 1 commit intomainfrom
fix/terraform-ls-skill-conventions
Mar 20, 2026
Merged

fix(terraform-ls): add missing skill name field and migrate to subdirectory format v1.0.1#14
vnz merged 1 commit intomainfrom
fix/terraform-ls-skill-conventions

Conversation

@vnz
Copy link
Copy Markdown
Owner

@vnz vnz commented Mar 20, 2026

Summary

  • Add missing name field to tf-explain SKILL.md frontmatter (required by marketplace import)
  • Migrate skill from flat format (skills/tf-explain.md) to subdirectory format (skills/tf-explain/SKILL.md)
  • Improve skill description to use third-person trigger phrases per skill-development best practices
  • Bump version to 1.0.1

Context

The name field in SKILL.md frontmatter is required by the Claude.ai organization marketplace import process. Without it, the plugin fails to sync with error "missing required field in SKILL.md frontmatter: name". This was discovered during the aws-nuke/design-system plugin fixes (S2014) and the bash-ls plugin already follows the correct convention.

Test plan

  • Run prek run --all-files — all hooks pass
  • Run scripts/validate-plugins.sh — version 1.0.1 matches between plugin.json and marketplace.json
  • Verify skill loads after /plugin install terraform-ls@cc-plugins-vnz and /reload-plugins
  • Re-trigger marketplace sync in claude.ai organization settings — no import errors

🤖 Generated with Claude Code

…ectory format v1.0.1

The SKILL.md frontmatter was missing the required `name` field, which
causes marketplace import failures. Also migrates from flat skill
format to the recommended subdirectory format and improves the
description to use third-person trigger phrases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vnz vnz self-assigned this Mar 20, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical marketplace import issue for the terraform-ls plugin by introducing a previously missing name field in the SKILL.md frontmatter. It also refactors the skill's file structure to a new subdirectory format, enhances the skill description for better trigger phrase recognition, and updates the plugin version to 1.0.1 across relevant configuration files to reflect these changes.

Highlights

  • Marketplace Compatibility: Added the missing name field to the tf-explain SKILL.md frontmatter, which is required for successful marketplace import.
  • File Structure Migration: Migrated the tf-explain skill from a flat file format (skills/tf-explain.md) to a new subdirectory format (skills/tf-explain/SKILL.md).
  • Skill Description Enhancement: Improved the tf-explain skill description to incorporate third-person trigger phrases, aligning with skill-development best practices.
  • Version Bump: Bumped the terraform-ls plugin version from 1.0.0 to 1.0.1 across relevant configuration files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing name field to the tf-explain skill, migrates it to the subdirectory format, and bumps the version number. These changes address the marketplace import issue as described. I have one suggestion to improve the conciseness of the updated skill description in SKILL.md by separating the trigger phrases from the core capability description.

---
description: Explain Terraform resources, data sources, modules, and HCL syntax with provider-specific context. Use when user asks "what does this resource do", "explain this terraform", or needs help understanding infrastructure code.
name: Terraform Explanation
description: This skill should be used when the user asks to "explain this terraform resource", "what does this resource do", "explain this terraform", "help me understand this HCL", or needs help understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The updated skill description is a bit long and combines trigger phrases with a general description in a single sentence, which makes it slightly hard to read.

To improve clarity and conciseness, you could separate the list of trigger phrases from the general description of the skill's capability. This also aligns with the general rule to keep AI skill documentation lean.

Suggested change
description: This skill should be used when the user asks to "explain this terraform resource", "what does this resource do", "explain this terraform", "help me understand this HCL", or needs help understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context.
description: This skill helps with understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context.
References
  1. Documentation for AI skills should be lean and focused on the 'why' and context of commonly misunderstood concepts, rather than being an exhaustive reference. Prioritize progressive disclosure over completeness to keep the primary document concise.

@vnz vnz merged commit 427f780 into main Mar 20, 2026
1 check passed
@vnz vnz deleted the fix/terraform-ls-skill-conventions branch March 20, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant