Conversation
…ectory format v1.0.1 The SKILL.md frontmatter was missing the required `name` field, which causes marketplace import failures. Also migrates from flat skill format to the recommended subdirectory format and improves the description to use third-person trigger phrases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical marketplace import issue for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing name field to the tf-explain skill, migrates it to the subdirectory format, and bumps the version number. These changes address the marketplace import issue as described. I have one suggestion to improve the conciseness of the updated skill description in SKILL.md by separating the trigger phrases from the core capability description.
| --- | ||
| description: Explain Terraform resources, data sources, modules, and HCL syntax with provider-specific context. Use when user asks "what does this resource do", "explain this terraform", or needs help understanding infrastructure code. | ||
| name: Terraform Explanation | ||
| description: This skill should be used when the user asks to "explain this terraform resource", "what does this resource do", "explain this terraform", "help me understand this HCL", or needs help understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context. |
There was a problem hiding this comment.
The updated skill description is a bit long and combines trigger phrases with a general description in a single sentence, which makes it slightly hard to read.
To improve clarity and conciseness, you could separate the list of trigger phrases from the general description of the skill's capability. This also aligns with the general rule to keep AI skill documentation lean.
| description: This skill should be used when the user asks to "explain this terraform resource", "what does this resource do", "explain this terraform", "help me understand this HCL", or needs help understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context. | |
| description: This skill helps with understanding Terraform resources, data sources, modules, and HCL syntax with provider-specific context. |
References
- Documentation for AI skills should be lean and focused on the 'why' and context of commonly misunderstood concepts, rather than being an exhaustive reference. Prioritize progressive disclosure over completeness to keep the primary document concise.
Summary
namefield to tf-explain SKILL.md frontmatter (required by marketplace import)skills/tf-explain.md) to subdirectory format (skills/tf-explain/SKILL.md)Context
The
namefield in SKILL.md frontmatter is required by the Claude.ai organization marketplace import process. Without it, the plugin fails to sync with error "missing required field in SKILL.md frontmatter: name". This was discovered during the aws-nuke/design-system plugin fixes (S2014) and the bash-ls plugin already follows the correct convention.Test plan
prek run --all-files— all hooks passscripts/validate-plugins.sh— version 1.0.1 matches between plugin.json and marketplace.json/plugin install terraform-ls@cc-plugins-vnzand/reload-plugins🤖 Generated with Claude Code