Skip to content

Fix Annotation.__init__ to handle length-zero Sequence, fixes #290#291

Merged
NickleDave merged 1 commit intomainfrom
fix-bug-with-annotation-from-length-zero-sequence
Jul 17, 2025
Merged

Fix Annotation.__init__ to handle length-zero Sequence, fixes #290#291
NickleDave merged 1 commit intomainfrom
fix-bug-with-annotation-from-length-zero-sequence

Conversation

@NickleDave
Copy link
Copy Markdown
Collaborator

@NickleDave NickleDave commented Jul 17, 2025

Fix for #290 -- changes Annotation.__init__ so we check if seq is not None: instead of just doing if seq:, to avoid the edge case where a length-zero Sequence with no segments evaluates to False. Adds a unit test to check for this

@NickleDave NickleDave added the BUG: bug Something isn't working label Jul 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.08%. Comparing base (97e0dd0) to head (c683d29).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   94.20%   94.08%   -0.12%     
==========================================
  Files          43       43              
  Lines        1759     1692      -67     
==========================================
- Hits         1657     1592      -65     
+ Misses        102      100       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NickleDave NickleDave merged commit b148b3c into main Jul 17, 2025
13 of 14 checks passed
@NickleDave NickleDave deleted the fix-bug-with-annotation-from-length-zero-sequence branch July 17, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUG: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant