fix: source TRACK from check_exists (IN-3577)#372
Conversation
theProf
changed the title
|
Your development orb has been published. It will expire in 30 days. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a script integration issue where create_manifest.sh was redefining the TRACK variable instead of reusing the value already computed in check_exists.sh. The fix exports TRACK from check_exists.sh via the TRACK_STATUS file and removes the redundant definition in create_manifest.sh.
Changes:
- Export
TRACKvariable fromcheck_exists.shalongsideTRACK_EXISTS - Remove redundant
TRACKdefinition increate_manifest.sh - Code formatting improvements (indentation)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/scripts/track/check_exists.sh | Exports TRACK variable to TRACK_STATUS file for reuse by other scripts; includes formatting improvements |
| src/scripts/docker/create_manifest.sh | Removes redundant TRACK definition, now relies on sourced value from TRACK_STATUS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theProf
force-pushed
the
greg/update-track-tag-push/IN-3577
branch
from
1e401f3 to
6d9f6e2
Compare
|
Your development orb has been published. It will expire in 30 days. |
|
Your development orb has been published. It will expire in 30 days. |
theProf
force-pushed
the
greg/update-track-tag-push/IN-3577
branch
from
1ddcc26 to
87f0f57
Compare
|
Your development orb has been published. It will expire in 30 days. |
|
Updated the PR after approval. I moved the gtmq logic into check_exists and out of both update_track and create_manifest |
|
Your orb has been published to the CircleCI Orb Registry. |
Description
If we use
TRACK_EXISTSfromcheck_exists.sh, we should re-use the track it checked