feat: add mintlify docs publish job (ENG-841)#374
Conversation
|
Your development orb has been published. It will expire in 30 days. |
|
Your development orb has been published. It will expire in 30 days. |
| at: ~/voiceflow | ||
| - install_node_modules | ||
| - openapi_restore_schemas: | ||
| attach_workspace: true |
There was a problem hiding this comment.
can this be false since the workspace is already attached at the same location on line 17?
There was a problem hiding this comment.
it actually does something slightly different
https://github.com/voiceflow/orb-common/blob/master/src/commands/openapi/openapi_restore_schemas.yml#L22
There was a problem hiding this comment.
ah, right, it's using the fromfor the attach, thanks
| cd apps | ||
| cp -v --parents */openapi.public.json ~/docs/specs | ||
|
|
||
| cd ~/docs |
There was a problem hiding this comment.
not enough to block or use a variable (since it's not an input), but may want to comment that lines 29, 36, 38 are expected to use the same path
| cd ~/docs | ||
| git config --global user.email "serviceaccount@voiceflow.com" | ||
| git config --global user.name "Voiceflow" | ||
| git add specs/*/openapi.public.json |
There was a problem hiding this comment.
of note, but no actual change request. this pattern of commiting from master to master causes issues, but this PR is following our current patterns
There was a problem hiding this comment.
this commits to master in a different repo though... I don't think that's been causing any issues has it?
we use the same approach for publishing to openapi-schemas and I haven't seen any issues there
There was a problem hiding this comment.
oh that is correct, thanks for the clarification. are there any other places that will merge/commit to master of that repo, or is this the only place it happens?
|
Your development orb has been published. It will expire in 30 days. |
|
Your orb has been published to the CircleCI Orb Registry. |
4 participants
Tested on
platformwith this PR