feat: write changed files to file not env (IN-1254)#391
Conversation
|
Your development orb has been published. It will expire in 30 days. |
theProf
force-pushed
the
ogrady/changed-files-to-file/IN-1254
branch
from
8e44f2b to
731a0fd
Compare
|
Your development orb has been published. It will expire in 30 days. |
|
Your orb has been published to the CircleCI Orb Registry. |
4 participants
TL;DR
Replaces the
CHANGED_FILESenvironment variable (which stored file contents inline) withCHANGED_FILES_FILE, a path to a file containing the list of changed files.What changed?
The
get_changed_filescommand no longer stores the git diff output in aCHANGED_FILESenvironment variable. Instead, it writes the output directly to a file (defaulting to/tmp/changed_files.txt) and exportsCHANGED_FILES_FILEpointing to that path. All consumers (set-if-file-changed,set-service-data-json, andget_modified_charts.sh) have been updated to read from the file path rather than the inline environment variable.How to test?
Run a pipeline that uses the
get_changed_filescommand followed by any of the dependent commands (set-if-file-changed,set-service-data-json, or helm chart detection). Verify that changed files are correctly detected and the appropriate environment variables are set as expected.Why make this change?
Storing large amounts of file change data inline in an environment variable is fragile — it can break with special characters, newlines, or when the diff is large. Writing to a file is more robust. Additionally, using an absolute path (
/tmp/changed_files.txt) ensures the file remains accessible to consumers that set a customworking_directory(e.g. helm jobs), where a relative path would not survive the directory change.