Skip to content

New package: gwe-0.15.2#29380

Merged
Chocimier merged 5 commits intovoid-linux:masterfrom
LegoLivesMatter:master
Mar 20, 2021
Merged

New package: gwe-0.15.2#29380
Chocimier merged 5 commits intovoid-linux:masterfrom
LegoLivesMatter:master

Conversation

@LegoLivesMatter
Copy link
Copy Markdown
Contributor

@LegoLivesMatter LegoLivesMatter commented Mar 10, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr added the new-package This PR adds a new package label Mar 10, 2021
@Chocimier
Copy link
Copy Markdown
Member

Add required packages to depends and hostmakedepends and drop usage of pip.

@LegoLivesMatter
Copy link
Copy Markdown
Contributor Author

Add required packages to depends and hostmakedepends and drop usage of pip.

Some of the required Python modules are not currently in the repos and I will need to package them, should I add them in a separate PR or integrate them into this PR somehow?

@Chocimier
Copy link
Copy Markdown
Member

Please put in this PR, one commit per template.

@LegoLivesMatter LegoLivesMatter changed the title New package: greenwithenvy-0.15.2 [WIP] New package: greenwithenvy-0.15.2 Mar 11, 2021
@LegoLivesMatter LegoLivesMatter marked this pull request as draft March 11, 2021 13:45
@LegoLivesMatter LegoLivesMatter marked this pull request as ready for review March 11, 2021 14:43
@LegoLivesMatter LegoLivesMatter changed the title [WIP] New package: greenwithenvy-0.15.2 New package: greenwithenvy-0.15.2 Mar 11, 2021
Copy link
Copy Markdown
Member

@Chocimier Chocimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, I will need to look at that.

Comment thread srcpkgs/greenwithenvy/template Outdated
Comment thread srcpkgs/python3-coveralls/template Outdated
Comment thread srcpkgs/python3-injector/template Outdated
@Chocimier
Copy link
Copy Markdown
Member

nvml passes tests with checkdepends="python3-xmltodict", injector with checkdepends="python3-pytest-cov".
coveralls requires some unpackaged modules, you can mark make_check=no # requires pytest-pep8, httpretty or add them.

@Chocimier
Copy link
Copy Markdown
Member

Last thing i would change is rename to "gwe", like upstream repo name and like other distros call it.

@LegoLivesMatter LegoLivesMatter marked this pull request as draft March 18, 2021 20:06
@LegoLivesMatter LegoLivesMatter marked this pull request as ready for review March 18, 2021 20:15
@LegoLivesMatter LegoLivesMatter changed the title New package: greenwithenvy-0.15.2 New package: gwe-0.15.2 Mar 18, 2021
@Chocimier
Copy link
Copy Markdown
Member

INSTALL.msg is now limited to critical information, like preventing breakage of system. Move to readme.voidlinux or remove, as nonfree driver need can be understood from interface message.

@Chocimier Chocimier merged commit 500dc11 into void-linux:master Mar 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants