Skip to content

mumble: update to 1.4.230.#35102

Merged
paper42 merged 1 commit intomasterfrom
unknown repository
Jan 23, 2022
Merged

mumble: update to 1.4.230.#35102
paper42 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 18, 2022

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

@stacyharper
Copy link
Copy Markdown

stacyharper commented Jan 18, 2022

Does it need some new pipewire devel make depencencies ?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 18, 2022 •
edited by ghost
Loading

Does it need some new pipewire devel make depencencies ?

Not that I'm aware. I noticed, though, that you need pipewire-devel installed at runtime for mumble to recognize that it's available.

It's possible, though that adding pipewire-devel to the template might resolve this and make pipewire work as expected.

EDIT: I added pipewire-devel to makedepends and it seems to behave the same. I don't really understand why it needs the devel package at runtime.

@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 20, 2022

Could you try removing depends=mumble from murmur and testing if it still works as expected? #35110 (comment)

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 20, 2022 •
edited by ghost
Loading

@paper42 , It seems to build and work. Is there anything else?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 20, 2022

Does it need some new pipewire devel make depencencies ?

@stacyharper , In case you haven't also, I looked into this a little bit more and it seems like mumble manages loading the pipewire library fully at runtime.

@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 20, 2022

This update was done in 5f589a9, @Hoshpak probably didn't see this PR. Could you look at the changes, rebase this PR and include only the ones which make sense and are not part of 5f589a9? At least removing depends=mumble from murmur is important.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 20, 2022

Could you look at the changes, rebase this PR and include only the ones which make sense

Done. I think everything is in order now

@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 21, 2022

please increase the revision, then I think this is good to go

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 21, 2022

Ok, it is done

@paper42
Copy link
Copy Markdown
Member

paper42 commented Jan 21, 2022

the commit message should be changed, this is not an update anymore

@dexgs
mumble: remove murmur dependency on mumble
75438d1 
Remove the dependency on mumble from the murmur subackage. Also change
the `short_desc` and `homepage` fields to reflect the Mumble project's
current website.
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 22, 2022

Okay, i've changed the commit message to describe the changes to the template

@paper42 paper42 merged commit 1a2ea3c into void-linux:master Jan 23, 2022
@dexgs dexgs deleted the mumble branch January 23, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stacyharper @paper42 @dexgs