Skip to content

dunst: update to 1.12.0.#53392

Merged
classabbyamp merged 1 commit intovoid-linux:masterfrom
reedts:dunst_v1.12.0
Mar 7, 2025
Merged

dunst: update to 1.12.0.#53392
classabbyamp merged 1 commit intovoid-linux:masterfrom
reedts:dunst_v1.12.0

Conversation

@reedts
Copy link
Contributor

@reedts reedts commented Dec 7, 2024

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • aarch64
    • armv7l
    • armv7l-musl

@biopsin
Copy link
Contributor

biopsin commented Dec 9, 2024

upstream issue dunst-project/dunst#1404

@bynect
Copy link

bynect commented Dec 18, 2024

Hi, which docker file is being used for the build workflow?

@biopsin
Copy link
Contributor

biopsin commented Dec 21, 2024

@reedts would you mind updating to 1.12.1

@reedts
Copy link
Contributor Author

reedts commented Dec 21, 2024

@biopsin Done.

@biopsin
Copy link
Contributor

biopsin commented Dec 22, 2024

@reedts Please squash commits and force push.

@reedts
Copy link
Contributor Author

reedts commented Dec 23, 2024

@biopsin Done as well ;).

@bynect
Copy link

bynect commented Jan 13, 2025

The ci failure is due to a lack of font. maybe add a virtual font dependency to checkdepends

@reedts
Copy link
Contributor Author

reedts commented Jan 14, 2025

@bynect: Thank you! Adding a font indeed fixes the ci failures.
@biopsin: Are you fine with this solution? Should we include a specific font in this case?

@biopsin
Copy link
Contributor

biopsin commented Jan 14, 2025

@reedts Solution is fine, I dont know of any more basic font to use. Looking thru some other templates and many use cantarell-fonts pkg but to me it does not matter.

@bynect
Copy link

bynect commented Jan 14, 2025

In gentoo we have virtual/ttf-fonts. I don't know if void has a similar virtual package mechanism. but the change you made seem fine anyway

@mdkcore0
Copy link
Contributor

mdkcore0 commented Mar 7, 2025

@reedts mind updating to 1.12.2?

@mdkcore0
Copy link
Contributor

mdkcore0 commented Mar 7, 2025

LGTM, thanks!

@classabbyamp classabbyamp merged commit 7d83669 into void-linux:master Mar 7, 2025
8 checks passed
@reedts reedts deleted the dunst_v1.12.0 branch February 17, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants