Skip to content

yggdrasil: ypdate to 0.5.11#53497

Closed
terminaldweller wants to merge 1 commit intovoid-linux:masterfrom
terminaldweller:yggdrasil_0_5_11
Closed

yggdrasil: ypdate to 0.5.11#53497
terminaldweller wants to merge 1 commit intovoid-linux:masterfrom
terminaldweller:yggdrasil_0_5_11

Conversation

@terminaldweller
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl

@terminaldweller
Copy link
Contributor Author

#53207 had the same issue as in the same tests were not passing.
I've ran the tests and they pass on my x86_64-glibc box.
I'm suspecting this is a problem with the runners but I don't know where I can start looking at that. I would appreciate some directions.

@terminaldweller
Copy link
Contributor Author

That specific test is failing because it is being run as root.
@classabbyamp confirmed that runners run the test as root and i tried running the test on my box as root and it failed.
Putting this here for future reference.

@terminaldweller
Copy link
Contributor Author

The test that was failing has been removed: yggdrasil-network/yggdrasil-go@657f7e0
Now we wait for a new release
Should I close this now, or keep this until the new yggdrasil release?

@neilalexander
Copy link

New release is up BTW that includes the fix: https://github.com/yggdrasil-network/yggdrasil-go/releases/tag/v0.5.12

@terminaldweller
Copy link
Contributor Author

I know. I built it and now I'm testing it.

@terminaldweller
Copy link
Contributor Author

closed in favour of #53572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants