base-files: fix /etc/profile call to unset appendpath

[NyaaaWhatsUpDoc]

Testing the changes

• I tested the changes in this PR: YES

Have confirmed this behaviour of unset in bash, mksh and dash myself. And to quote the unset section of the manpage for sh:

     unset [-fv] name ...
            The specified variables and functions are unset and unexported.
            If -f or -v is specified, the corresponding function or variable
            is unset, respectively.  If a given name corresponds to both a
            variable and a function, and no options are given, only the
            variable is unset.

[mtboehlke]

Thanks for bringing this up. Imho I think this is a good change for consistent behavior across multiple shells.

I actually made this change a while ago on my machine (and even made a noextract entry for /etc/profile), but kind of forgot about it. I use oksh as the login shell, which is why I think I noticed it at all. From what I can tell, bash will happily unset the function even without the -f flag, as long as there isn't a variable with the same name. The man page makes it sound like maybe that's what dash will do as well, but I don't think that's true. At least oksh and dash seem to require -f to unset a function.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.