Skip to content

nextcloud-client: update to 3.15.3.#54447

Closed
tornaria wants to merge 1 commit intovoid-linux:masterfrom
tornaria:nextcloud
Closed

nextcloud-client: update to 3.15.3.#54447
tornaria wants to merge 1 commit intovoid-linux:masterfrom
tornaria:nextcloud

Conversation

@tornaria
Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@tornaria
Copy link
Copy Markdown
Contributor Author

tornaria commented Feb 22, 2025

@mdkcore0 here's an update to current nextcloud-client.

There's one failing test on i686 which I don't know what to do about. it's about files > 2G and it already fails in the current version 3.13.3, but since ci test was disabled we don't know how old is this! Maybe it's a false positive but maybe it's an actual bug; this fails locally as well (did you ever tested i686 locally? since you have ci test disabled you should...)

I enabled ci testing and there are three further failures in all architectures that are possibly false positives (fail only on CI, not locally):

FAIL!  : TestSyncVirtualFiles::testLockFile_lockedFileReadOnly_afterSync() '!localFileLocked.isWritable()' returned FALSE. ()
FAIL!  : TestDownload::testMoveFailsInAConflict() '!fakeFolder.syncOnce()' returned FALSE. ()
FAIL!  : TestLockFile::testLockFile_lockedFileReadOnly_afterSync() '!localFileLocked.isWritable()' returned FALSE. ()

I should point out that the first two tests are present in owncloudclient and they pass, so it's possible that there are fixes to be found in there. See https://github.com/void-linux/void-packages/actions/runs/13249328574/job/36983286864?pr=54279#step:7:2675

@tornaria tornaria force-pushed the nextcloud branch 2 times, most recently from f564d20 to 0aa09bd Compare February 22, 2025 21:16
@tornaria
Copy link
Copy Markdown
Contributor Author

Fixed CI by skipping some tests when getuid() == 0. This could be upstreamed.

The i686 failure remains but it's not new.

@mdkcore0
Copy link
Copy Markdown
Contributor

hey, thanks for it! I will try to build your branch here (maybe tommorrow), and check how we can manage to get it merged asap :D

@tornaria
Copy link
Copy Markdown
Contributor Author

tornaria commented May 2, 2025

@mdkcore0 in the end, I didn't like this client and I'll stick to owncloudclient, so I'm not working on this anymore.

Feel free to work on this starting with the changes here. There's now a new version of nextcloud-client (3.16.4), it needs some libp11 which is not available in void, you will need to package that.

@tornaria tornaria closed this Jun 7, 2025
@mdkcore0
Copy link
Copy Markdown
Contributor

hi @tornaria, sorry for not being able to answer before; finally I will have some time after next week, so I'll try to update it following what you achieved, many thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants