Skip to content

coreutils: update to 9.7#55244

Open
dkwo wants to merge 2 commits intovoid-linux:masterfrom
dkwo:coreutils
Open

coreutils: update to 9.7#55244
dkwo wants to merge 2 commits intovoid-linux:masterfrom
dkwo:coreutils

Conversation

@dkwo
Copy link
Contributor

@dkwo dkwo commented May 4, 2025

  • I tested the changes in this PR: yes
  • I built this PR locally for my native architecture, (aarch64-glibc)

Remark: 4 new musl test failures, the rest was already failing on master branch.

@dkwo dkwo force-pushed the coreutils branch 11 times, most recently from 37fd43f to 8781037 Compare July 10, 2025 18:59
@dogknowsnx
Copy link
Contributor

dogknowsnx commented Aug 18, 2025

Testing coreutils-9.7coreutils-9.9 right now - will report back in a couple of days..
EDIT: No issues after 4 weeks of running v9.9 on a daily basis..

@classabbyamp classabbyamp added the core core package label Jan 1, 2026
@dkwo
Copy link
Contributor Author

dkwo commented Jan 12, 2026

I will take a look at v9.9, I guess we need to backport

cp, install, and mv no longer enter an infinite loop copying sparse files
with SEEK_HOLE.  E.g., this was seen on ext4 when copying sparse files with
extents that are being actively updated, and copy offload is not being used.
[bug introduced in coreutils-9.9]

'date' no longer fails with format directives that return an empty string.
[bug introduced in coreutils-9.9]

@dogknowsnx
Copy link
Contributor

dogknowsnx commented Jan 13, 2026

I will take a look at v9.9, I guess we need to backport

cp, install, and mv no longer enter an infinite loop copying sparse files
with SEEK_HOLE.  E.g., this was seen on ext4 when copying sparse files with
extents that are being actively updated, and copy offload is not being used.
[bug introduced in coreutils-9.9]

'date' no longer fails with format directives that return an empty string.
[bug introduced in coreutils-9.9]

Right, I'm actually using that patch but forgot about it:

copy-fix-possible-infinite-loop-with-SEEK_HOLE.patch:

--- a/src/copy-file-data.c
+++ b/src/copy-file-data.c
@@ -338,7 +338,7 @@ lseek_copy (int src_fd, int dest_fd, char **abuf, idx_t buf_size,
   for (off_t ext_start = scan_inference->ext_start;
        0 <= ext_start && ext_start < max_ipos; )
     {
-      off_t ext_end = (ext_start == ipos
+      off_t ext_end = (ext_start == src_pos
                        ? scan_inference->hole_start
                        : lseek (src_fd, ext_start, SEEK_HOLE));
       if (0 <= ext_end)
-- 
2.51.2

Version 10 should be just around the corner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants