luajit: enable LUAJIT_ENABLE_LUA52COMPAT by default#55648
Conversation
|
|
|
done |
|
Why is this being done? It might not break ABI but it DOES break API and existing code by adding keywords (goto is a keyword, no longer a legal variable name), and changing return values (io.write() returns file handle instead of bool) |
|
aegisub requires it (TypesettingTools/Aegisub#239) ftr, both alpine and fedora build luajit with it enabled, so the damage is probably low. |
This comment was marked as outdated.
This comment was marked as outdated.
|
whether it builds or not is not necessarily relevant. it's often used to add scripting capability so it could be user code that breaks, like if someone uses |
|
That's the problem with interpreted languages, we cant test that this change works without breakage since any errors would be at runtime. In addition to users scripts breaking, like neovim configs, or plugins |
|
imo we’re making things unnecessarily complicated by keeping 5.2 compat optional. upstream distros have already gone through this decision, and the breakage is minimal and manageable. let’s just enable it and move forward. |
|
All things considered, I do agree that its probably best to enable 5.2 compat |
|
need to update checksum too, and squash commits |
|
done |
|
Could you re-run failed tests please? @classabbyamp |
|
you need to fix the lint anyways, force push |
This enables Lua 5.2 compatibility APIs without changing the ABI (still Lua 5.1). Required by some applications (e.g. Aegisub). Co-authored-by: Daniel Martinez <danielpedromartinez@duck.com>
|
ig we are good now. -revision=2
+revision=1 |
This enables Lua 5.2 compatibility APIs without changing the ABI (still Lua 5.1). Required by some applications (e.g. Aegisub). Co-authored-by: Daniel Martinez <danielpedromartinez@duck.com> Closes: void-linux#55648 [via git-merge-pr]
3 participants
This enables Lua 5.2 compatibility APIs without changing the ABI (still Lua 5.1).
Required by some applications (e.g. Aegisub(#55647)).