Conversation
srcpkgs/envision/template
Outdated
| version=3.2.0 | ||
| revision=1 | ||
| build_style=meson | ||
| hostmakedepends="rust cargo git pkg-config gettext desktop-file-utils" |
There was a problem hiding this comment.
| hostmakedepends="rust cargo git pkg-config gettext desktop-file-utils" | |
| build_helper="rust" | |
| hostmakedepends="git pkg-config gettext desktop-file-utils" |
There was a problem hiding this comment.
It still needs rust in hostmakedepends for rustc, otherwise the following error occurs:
meson.build:1:0: ERROR: Unknown compiler(s): [['rustc']]
The following exception(s) were encountered:
Running `rustc --version` gave "[Errno 2] No such file or directory: 'rustc'"
There was a problem hiding this comment.
My bad, I thought setting the build_helper would automatically add that dependency.
Nevertheless it makes sense to add rust as build helper, that sets all the rust compiler flags commonly used for Void and might help with cross compiling
srcpkgs/envision/template
Outdated
| version=3.2.0 | ||
| revision=1 | ||
| build_style=meson | ||
| hostmakedepends="rust cargo git pkg-config gettext desktop-file-utils" |
There was a problem hiding this comment.
Why is git required at build time?
Usually that means that the app is trying to parse some information of its git repository (e.g. commit hash), but in our case the tar.gz distfile doesn't contain the git repo information anyways, so it can/should be patched out. Not sure if that's also the case here though
There was a problem hiding this comment.
From the meson.build file I can see that git is used to check if the build is a tagged release:
opt_profile = get_option('profile')
# if a profile isn't specified infer from git
if opt_profile == 'default'
# are we building a tagged version?
if run_command('git', 'describe', '--tags', '--exact-match').returncode() != 0
I can probably define a profile and skip this step.
There was a problem hiding this comment.
Using configure_args="-Dprofile=release" solves this and is a good idea to use anyways since this is a release build and does not need the -devel suffix in the about section which would otherwise be present.
|
I've rebased my branch and added configure_args + |
3 participants
Testing the changes
New package
Local build testing
This PR adds a package for Envision (https://gitlab.com/gabmus/envision) which is otherwise only available as an Appimage. This native package has a couple of benefits like better desktop integration (correct scaling) and working "open folder" buttons which won't be fixed in the Appimage (see https://gitlab.com/gabmus/envision/-/issues/96).
The libclang patch is necessary for the included dependency checker to work in the current release, but is already merged and will therefore not be necessary in the next tagged release, see MR.