Skip to content

New package: gtrash-0.0.6#58211

Open
yushisora wants to merge 1 commit intovoid-linux:masterfrom
yushisora:gtrash
Open

New package: gtrash-0.0.6#58211
yushisora wants to merge 1 commit intovoid-linux:masterfrom
yushisora:gtrash

Conversation

@yushisora
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (aarch64-glibc)

@yushisora
Copy link
Contributor Author

The failed build may due to the package requires docker compose to run the test.

In the Makefile:

itest:
	mkdir -p itest/coverage
	go build -cover
	docker compose run itest

How to run the test in this case or is it okay to use make_check=no to skip it?

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Dec 23, 2025
Copy link
Contributor

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests running in docker should be disabled, yes. See e.g.

make_check=no # tests require a running docker daemon
.

However, for this package, not all tests require docker, so we can just execute the ones that require no docker:

diff --git a/srcpkgs/gtrash/template b/srcpkgs/gtrash/template
index 35de1885c45..d2f3179f97b 100644
--- a/srcpkgs/gtrash/template
+++ b/srcpkgs/gtrash/template
@@ -12,6 +12,10 @@ changelog="https://github.com/umlx5h/gtrash/releases"
 distfiles="https://github.com/umlx5h/gtrash/archive/refs/tags/v${version}.tar.gz"
 checksum=66003276073d9da03cbb4347a4b161f89c81f3706012b77c3e91a154c91f3586
 
+do_check() {
+	make test
+}
+
 post_install() {
 	vlicense LICENSE
 }

@yushisora
Copy link
Contributor Author

@Bnyro Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants