Skip to content

Conversation

@yushisora
Copy link
Contributor

It is mentioned in #54741 that a patch is added in b21778d to replace imghdr with magic but then python3-magic is missing from epy dependency.

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (aarch64-glibc)

@yushisora
Copy link
Contributor Author

PYTHON: py3:magic <-> UNKNOWN PKG PLEASE FIX!

Any tips on how to fix it?

@classabbyamp
Copy link
Member

the patch should be adjusted to add a dependency on python-magic (what we package as python3-magic), as that's a different thing than magic

@Rutpiv
Copy link
Contributor

Rutpiv commented Dec 30, 2025

Replacing +magic = { version = "*" } with +python-magic = { version = "*" } in no-imghdr.patch is enough to resolve the issue. The functions used are compatible, and after testing, image detection works as expected.

I also noticed that python3-magic in Void was outdated, so I updated the template accordingly. The corresponding PR is here: #58336

@yushisora
Copy link
Contributor Author

Thanks. Already changed the patch as suggested.

@classabbyamp classabbyamp merged commit 9f8ea20 into void-linux:master Dec 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants