Conversation
|
I will have to look into the musl build |
ahesford
left a comment
There was a problem hiding this comment.
I'm not sure that the service should be tweaking sysctls. Let people configure their systems to support the daemon if they want to run it. In any case, there is no good reason for using two different approaches to setting sysctls in the run and finish scripts.
2152e35 to
61068aa
Compare
I took that part out. Should I provide some sort of sysctl.d/ananicy.conf example file? |
|
No, users can be expected to read the upstream documentation regarding sysctls. If it isn't documented upstream, maybe add a note in README.voidlinux. |
As I understand it, ananicy-cpp supports autogroups anyway; no need for the sysctls. As for ananicy itself, I've been using it for the past couple weeks now without issues. |
Testing the changes
New package
Local build testing
With the cross-build fixes also for: x86_64-musl, aarch64-glibc, aarch64-musl