feat: add experimental support for Darwin #623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
darwin
branch
3 times, most recently
from
680a07b to
e31dc63
Compare
shanduur
changed the title
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Instead of having a dict with pkgvers as keys and iterating over all keys to match virtual packages, change the map to have pkgnames as keys, which hold another dict with all the old keys and values for a given package name. This significantly speeds up XBPS, since for every package it would iterate over the whole virtual package map. With recent changes to xbps-src, where it generates cmd: and py3: virtual packages, the number of virtual packages in the map has been growing a lot.
By combining repodata and stage data into a single file its easier to use remote stagedata when enabled. This also avoids having to come up with a new mechanism to fetch -stagedata and having to keep -repodata and -stagedata in sync.
this is done to avoid losing the lock when the packackage database is replaced with a new file (during updates).
when a package was removed while the repoistory was staged it would write the merged index+stage into to the repository datas index while also keeping the repository staged. This is fixed by operating on the index without the stage. (maybe should have more clear variable names than idx and index)
Fixed a second typo found commit 6142fff Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving cross-platform compatibility, particularly for macOS (Darwin) systems.
The primary goal is to ensure the software builds on both macOS and Linux. These changes specifically address the differences in dynamic linking and shared library management between the two operating systems, preventing build failures or runtime issues related to missing libraries or incompatible compiler flags on macOS.