Fix Install Script Permissions for Those Using Dev Containers#18
Closed
callbacked wants to merge 1 commit intovoideditor:mainfrom
Closed
Fix Install Script Permissions for Those Using Dev Containers#18callbacked wants to merge 1 commit intovoideditor:mainfrom
callbacked wants to merge 1 commit intovoideditor:mainfrom
Conversation
Contributor
|
We shouldn't need to modify this file. Users with permission errors should be able to chmod files themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning the repo for the first time and spinning it up as a dev container using the predefined
./devcontainerfolder led me to permission denied errors for:For
install-vscode.sh, what I did is add an entry to add exec permissions in the Dockerfile.For
post-create.sh, since its not referenced in the Dockerfile, I directly applied exec permissions to the file throughchmod +x. So 644 to 755.