fix: recurse into HTML elements within ICU branches to extract interpolation placeholders#20
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 10, 2026
Conversation
…olation placeholders
When ICU case text contains interpolations inside HTML elements like
`<strong>{{ expr }}</strong>`, `extract_placeholders_from_nodes` was
silently dropping them because it only handled Text and Expansion nodes.
This caused fewer i18nExp calls than Angular emits (e.g., 5 instead of 8
for undo-toast-items.component.ts with nested ICU plurals).
Add HtmlNode::Element recursion to match Angular's i18n_parser.ts
visitElement behavior which recursively visits children.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ICU case text contains interpolations inside HTML elements like
<strong>{{ expr }}</strong>,extract_placeholders_from_nodeswas silently dropping them because it only handled Text and Expansion nodes. This caused fewer i18nExp calls than Angular emits (e.g., 5 instead of 8 for undo-toast-items.component.ts with nested ICU plurals).Add HtmlNode::Element recursion to match Angular's i18n_parser.ts visitElement behavior which recursively visits children.
Note
Low Risk
Small, localized change to ICU placeholder extraction with a targeted regression test; main risk is subtle ordering/count differences in generated
i18nExparguments for templates with ICU + nested markup.Overview
Fixes ICU placeholder extraction so i18n processing no longer drops interpolations nested inside HTML elements within ICU branches by recursing into
HtmlNode::Elementchildren inextract_placeholders_from_nodes.Adds an integration test plus snapshot covering nested ICU plurals with markup like
<strong>{{ expr }}</strong>, asserting the generatedɵɵi18nExp(...)chain includes the expected expressions (e.g.,ctx.name,ctx.category).Written by Cursor Bugbot for commit 097d008. This will update automatically on new commits. Configure here.