fix(angular): emit ɵɵControlFeature from linker for controlCreate metadata#232
Merged
Brooooooklyn merged 1 commit intomainfrom Apr 16, 2026
Merged
fix(angular): emit ɵɵControlFeature from linker for controlCreate metadata#232Brooooooklyn merged 1 commit intomainfrom
Brooooooklyn merged 1 commit intomainfrom
Conversation
…adata The Angular Linker's build_features was ignoring the controlCreate property on ɵɵngDeclareDirective, so directives like @angular/forms/signals FormField were linked without ɵɵControlFeature(passThroughInput). This left DirectiveDef.controlDef unset at runtime, making template-emitted ɵɵcontrolCreate()/ɵɵcontrol() calls no-ops and breaking [formField] bindings with NG0950. Mirrors Angular TS compiler.ts:151-155. Fixes #229 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Angular Linker's build_features was ignoring the controlCreate property
on ɵɵngDeclareDirective, so directives like @angular/forms/signals FormField
were linked without ɵɵControlFeature(passThroughInput). This left
DirectiveDef.controlDef unset at runtime, making template-emitted
ɵɵcontrolCreate()/ɵɵcontrol() calls no-ops and breaking [formField] bindings
with NG0950. Mirrors Angular TS compiler.ts:151-155.
Fixes #229
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Low Risk
Small, targeted change to feature emission for a specific metadata field, with added regression tests reducing the chance of unintended output changes.
Overview
Fixes the linker’s
build_featuresto recognizecontrolCreatein directive/component partial metadata and appendns.ɵɵControlFeature(passThroughInput)(string ornull) to the generatedfeaturesarray in the correct order.Adds regression coverage via new snapshot tests for both pass-through and
nullcases, plus an e2e fixture reproducing the[formField]alias binding issue from #229.Reviewed by Cursor Bugbot for commit 9a00cca. Bugbot is set up for automated code reviews on this repo. Configure here.