fix: skip optimize_save_restore_view for Animation handler_ops#3
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
Angular's ngtsc keeps restoreView/resetView in animation callbacks even when the return value doesn't reference the view context (e.g., `return "animate-in"`). OXC was incorrectly removing these via optimize_save_restore_view, causing 37 ClickUp component mismatches. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular's ngtsc keeps restoreView/resetView in animation callbacks even when the return value doesn't reference the view context (e.g.,
return "animate-in"). OXC was incorrectly removing these via optimize_save_restore_view, causing 37 ClickUp component mismatches.Note
Medium Risk
Changes variable optimization behavior for animation callbacks, which can affect generated template JS and runtime view/context handling in embedded views. Risk is moderate because it alters codegen semantics for animations but is narrowly scoped and covered by new integration snapshots.
Overview
Aligns codegen with Angular’s
ngtscby skippingoptimize_save_restore_viewforCreateOp::Animationhandler ops, preservingrestoreView/resetVieweven when the animation callback returns a simple literal.Adds integration coverage and snapshots for embedded-view (
@if) animations (both with and without a companion(click)listener) to ensuregetCurrentViewand the appropriaterestoreView/resetViewcalls remain in the output and_unnamed_references don’t appear.Written by Cursor Bugbot for commit 5070286. This will update automatically on new commits. Configure here.