fix(angular): emit localRefs and templateRefExtractor for conditional create instructions#35
Merged
Brooooooklyn merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
… create instructions Angular's conditionalCreate and conditionalBranchCreate instructions support localRefs arguments (refs index + templateRefExtractor) when local template references are present. The Rust implementation was missing this, silently dropping the local_refs_index that the local_refs phase had already computed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Angular's conditionalCreate and conditionalBranchCreate instructions support
localRefs arguments (refs index + templateRefExtractor) when local template
references are present. The Rust implementation was missing this, silently
dropping the local_refs_index that the local_refs phase had already computed.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Low Risk
Small, localized change to emitted argument lists for conditional create instructions; risk is mainly limited to potential runtime signature mismatch if ordering/null-trimming differs from Angular.
Overview
Fixes control-flow create instruction generation so
@if/@switchbranches no longer drop local template references.create_conditional_create_stmtandcreate_conditional_branch_create_stmtnow acceptlocal_refs_indexand, when set, append the refs const index plusi0.ɵɵtemplateRefExtractorto match Angular’s instruction signatures;reify/mod.rsis updated to pass the computedlocal_refs_indexthrough. Adds unit tests asserting both the presence and omission of these arguments depending on whether local refs exist.Written by Cursor Bugbot for commit c41c96a. This will update automatically on new commits. Configure here.