feat: add SSR manifest plugin for AngularNodeAppEngine support#74
Merged
Brooooooklyn merged 2 commits intomainfrom Mar 5, 2026
Merged
feat: add SSR manifest plugin for AngularNodeAppEngine support#74Brooooooklyn merged 2 commits intomainfrom
Brooooooklyn merged 2 commits intomainfrom
Conversation
Add a Vite plugin that generates the Angular SSR manifests required by AngularNodeAppEngine, which previously threw "Angular app engine manifest is not set" because the OXC Vite plugin did not produce them. Changes: - New `angular-ssr-manifest-plugin.ts`: detects SSR builds and injects `ɵsetAngularAppManifest` and `ɵsetAngularAppEngineManifest` into files that reference AngularNodeAppEngine/AngularAppEngine - Add `ssrEntry` option to PluginOptions for specifying main.server.ts - Fix `ngServerMode` define to also be set during dev SSR builds - Add unit tests (vitest) and e2e tests (Playwright) for manifest generation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
napi/angular-compiler/vite-plugin/angular-ssr-manifest-plugin.ts
Outdated
Show resolved
Hide resolved
Use Vite's `normalizePath()` on the `relative()` output to convert backslash-separated Windows paths to forward slashes before interpolating into the `import()` expression. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Vite plugin that generates the Angular SSR manifests required by
AngularNodeAppEngine, which previously threw "Angular app engine manifest
is not set" because the OXC Vite plugin did not produce them.
Changes:
angular-ssr-manifest-plugin.ts: detects SSR builds and injectsɵsetAngularAppManifestandɵsetAngularAppEngineManifestinto filesthat reference AngularNodeAppEngine/AngularAppEngine
ssrEntryoption to PluginOptions for specifying main.server.tsngServerModedefine to also be set during dev SSR buildsCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Changes SSR build output by injecting code into detected server entries and tweaks build-time defines, which could affect SSR bundling/runtime if detection or paths are wrong. Coverage is improved via new unit and e2e tests, reducing regression risk.
Overview
Adds an SSR-only Vite plugin that auto-injects Angular SSR manifest setup into server entry modules that reference
AngularNodeAppEngine/AngularAppEngine, generating bothɵsetAngularAppManifest(includingmain.serverbootstrap +index.server.htmlasset) andɵsetAngularAppEngineManifest(entry points/locales/hosts).Extends the main
angular()plugin with a newssrEntryoption and wires the manifest plugin into the default plugin chain. Also adjusts the build optimizer songServerModeis defined in dev SSR builds (not just production), and adds Vitest unit tests plus a Playwright e2e build test to validate the injected output.Written by Cursor Bugbot for commit 67485de. This will update automatically on new commits. Configure here.