Conversation
The vp CLI caching was disabled due to a Windows `Cannot find module 'which'` issue (#10) and adds unnecessary complexity. This removes it entirely, including the force-install test matrix which halves CI jobs. Dependency caching (`cache: true`) is unaffected.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the (currently disabled) Vite+ (vp) CLI installation caching feature and simplifies CI by dropping the force-install matrix dimension, while leaving the existing dependency caching feature (cache: true) intact.
Changes:
- Remove vp CLI installation caching implementation (
src/cache-vp.ts) and its associated tests/docs/state keys. - Simplify the Vite+ install flow to always perform a fresh install (no vp cache restore attempt).
- Reduce CI matrix size by removing
force-installandSETUP_VP_FORCE_INSTALLfrom workflows.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Removes vp-cache-related State keys. |
| src/install-viteplus.ts | Drops vp cache restore/version resolution and simplifies install signature. |
| src/index.ts | Removes vp cache save in post step; updates install call site. |
| src/cache-vp.ts | Deletes vp CLI cache implementation. |
| src/cache-vp.test.ts | Deletes tests for the removed vp cache feature. |
| README.md | Removes documentation for vp installation cache. |
| .github/workflows/test.yml | Removes force-install matrix dimension and env var to halve CI combinations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cache-vp.ts) which was disabled due to WindowsCannot find module 'which'issue (Windows runner failures with latest action version #10)force-installtest matrix dimension andSETUP_VP_FORCE_INSTALLenv var from all CI jobs, halving the number of CI matrix combinationscache: true) is unaffectedTest plan
vp run typecheckpassesvp run testpasses (73 tests)vp run checkpassesvp run buildsucceeds🤖 Generated with Claude Code