refactor(ci): drop registry-url, rely on project .npmrc for auth#11
Merged
refactor(ci): drop registry-url, rely on project .npmrc for auth#11
Conversation
Uses the new setup-vp behavior from voidzero-dev/setup-vp#54: when NODE_AUTH_TOKEN is set, the action auto-generates a matching _authToken entry for each registry declared in the repo .npmrc. The repo .npmrc stays minimal (scope -> registry only) and no registry-url is needed in the workflow. Pinned to commit af4ffd9 on the PR branch until the change is released under @v1.
|
✅ Staging deployment successful! Preview: https://vp-setup-staging.void.app/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor CI/deploy workflows to use the new
setup-vpbehavior from voidzero-dev/setup-vp#54.registry-url: https://npm.pkg.github.comfrom allsetup-vpsteps in.github/workflows/ci.ymland.github/workflows/deploy.yml..npmrc(@void-sdk:registry=https://npm.pkg.github.com) plusNODE_AUTH_TOKENenv: the action auto-generates a matching_authTokenentry at$RUNNER_TEMP/.npmrcfor each registry declared in the project.npmrcthat doesn't already have one..npmrcstays minimal — no auth line needed.Pinning
Pinned to commit
af4ffd95e8c3d93e048fe8f03afeb2d4e3eba927(head of PR #54'sfix/respect-project-npmrcbranch) via a commented SHA. Bump back to@v1once the PR merges and is released.Test plan
testjob on this PR runsvp installsuccessfully (private@void-sdk/*packages resolve from GitHub Packages)staging-deployjob on this PR completesvpx void deploy