Merged
Conversation
- Merge UserConfigFile and UserConfigTasks into single UserRunConfig struct - Add cacheScripts field (Option<bool>, currently unused) - Rename config file from vite.config.json to vite-task.json - Rename task-config.ts to run-config.ts - Update TypeScript definition to export RunConfig type - Update all test fixtures and snapshots Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change UserConfigLoader::load_user_config_file to return anyhow::Result<Option<UserRunConfig>> instead of anyhow::Result<UserRunConfig>. Returns None when config file doesn't exist. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add `cacheScripts` field to enable cache for all package.json scripts - Validate that cacheScripts can only be set in workspace root config - Add CacheScriptsInNonRootPackage error for invalid usage - Refactor load() into two passes to extract and validate cacheScripts - Add test fixtures for cacheScripts behavior - Add cacheScripts: true to existing fixtures to maintain behavior Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add cache-scripts-error-non-root fixture to verify error message - Update plan snapshot test runner to handle task graph load errors Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, if a workspace root (with pnpm-workspace.yaml) had no package.json, the root vite-task.json was silently ignored. This change ensures a root package node is always added to the package graph, using PackageJson::default() when no package.json exists. This enables workspace-level config (like cacheScripts) and root-level tasks without requiring a root package.json. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
changed the title
cacheScripts in root config
Debug formatting escapes backslashes on Windows, breaking the path replacement in snapshot tests. Switch to Display formatting via a new Display impl on AbsolutePath. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
branchseer
force-pushed
the
feat_tasks_-_run_with_cacheScripts_
branch
from
f98d973 to
b16e3cd
Compare
fengmk2
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
cacheScriptsoption to enable caching for package.json scripts.What changed?
cacheScriptsoption that can be set in the workspace root's config file to enable caching for all package.json scriptstask-config.tstorun-config.tswith updated structureWhy make this change?
We don't want to cache scripts by default.