Skip to content

fix: match passthough envs with uppercased env names #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 1 commit into from
Nov 12, 2025
Merged

fix: match passthough envs with uppercased env names #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/vite_str/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ impl Str {
pub fn push_str(&mut self, s: &str) {
self.0.push_str(s);
}

pub fn to_uppercase(&self) -> Self {
Self(self.0.to_uppercase())
}

pub fn to_lowercase(&self) -> Self {
Self(self.0.to_lowercase())
}
}

impl AsRef<str> for Str {
Expand Down
5 changes: 3 additions & 2 deletions crates/vite_task/src/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ impl TaskEnvs {
GlobPatternSet::new(task.config.envs.iter().filter(|s| !s.starts_with('!')))?;
let sensitive_patterns = GlobPatternSet::new(SENSITIVE_PATTERNS)?;
for (name, value) in &all_envs {
if !envs_without_pass_through_patterns.is_match(name) {
let upper_name = name.to_uppercase();
if !envs_without_pass_through_patterns.is_match(&upper_name) {
continue;
}
let Some(value) = value.to_str() else {
Expand All @@ -267,7 +268,7 @@ impl TaskEnvs {
value: value.to_os_string(),
});
};
let value: Str = if sensitive_patterns.is_match(name) {
let value: Str = if sensitive_patterns.is_match(&upper_name) {
let mut hasher = Sha256::new();
hasher.update(value.as_bytes());
format!("sha256:{:x}", hasher.finalize()).into()
Expand Down