Skip to content

ci: replace global RUST_TEST_THREADS=1 with per-crate --test-threads=1 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 5 commits into from
Mar 21, 2026
+8 −4
Merged

ci: replace global RUST_TEST_THREADS=1 with per-crate --test-threads=1 #280

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
313f239
ci: replace global RUST_TEST_THREADS=1 with per-crate --test-threads=1
claude Mar 20, 2026
dfc6277
fix: use posix_spawn on musl to avoid fork() SIGSEGV in parallel tests
claude Mar 20, 2026
cb567c8
Revert "fix: use posix_spawn on musl to avoid fork() SIGSEGV in paral…
claude Mar 20, 2026
379b3d9
fix: use cargo-nextest on musl to run tests in parallel safely
claude Mar 20, 2026
c0a3c55
fix: exclude custom-harness packages from nextest, run them with carg…
claude Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,6 @@ jobs:
# -crt-static: vite-task is shipped as a NAPI module in vite+, and musl Node
# with native modules links to musl libc dynamically, so we must do the same.
RUSTFLAGS: --cfg tokio_unstable -D warnings -C target-feature=-crt-static
# On musl, concurrent PTY operations can trigger SIGSEGV in musl internals.
# Run test threads sequentially to avoid the race.
RUST_TEST_THREADS: 1
steps:
- name: Install Alpine dependencies
shell: sh {0}
Expand All @@ -175,7 +172,14 @@ jobs:
corepack enable
pnpm install

- run: cargo test
# Use cargo-nextest: it runs each test in its own process, avoiding
# musl's fork()-in-multithreaded-process SIGSEGV while keeping parallel
# execution (across processes instead of threads within one process).
# Exclude packages with custom test harnesses (harness = false) since
# nextest can't discover their tests; run those with cargo test instead.
- run: cargo install cargo-nextest --locked
- run: cargo nextest run --workspace --exclude vite_task_bin --exclude vite_task_plan
- run: cargo test -p vite_task_bin -p vite_task_plan

fmt:
name: Format and Check Deps
Expand Down
Loading