Skip to content

fix: merge synthetic task's input config with parent cache config#296

Merged
fengmk2 merged 1 commit intomainfrom
03-25-fix_merge_user_input_config_with_synthesized_input_config
Mar 25, 2026
Merged

fix: merge synthetic task's input config with parent cache config#296
fengmk2 merged 1 commit intomainfrom
03-25-fix_merge_user_input_config_with_synthesized_input_config

Conversation

@branchseer
Copy link
Member

Summary

  • When a synthetic task (e.g., vp lintoxlint) specifies input globs in its cache config, those were silently dropped during the merge with the parent task's config. Now resolves and merges them into the parent's ResolvedInputConfig.
  • The parent's includes_auto flag is preserved — the user's explicit choice always takes precedence over the synthetic handler's preference.
  • Threads package_dir separately from cwd so glob patterns are resolved relative to the correct base directory.

Test plan

  • 8 unit tests covering all merge cases: no input, globs merged, auto ignored, negative globs, cache disabled, etc.
  • All existing plan snapshot tests pass
  • Cross-platform paths in tests (Unix + Windows)

🤖 Generated with Claude Code

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@fengmk2 fengmk2 merged commit 2663222 into main Mar 25, 2026
9 checks passed
@fengmk2 fengmk2 deleted the 03-25-fix_merge_user_input_config_with_synthesized_input_config branch March 25, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants