fix(fspy): ignore malformed tracked paths without panicking#330
Open
SegaraRai wants to merge 4 commits intovoidzero-dev:mainfrom
Open
fix(fspy): ignore malformed tracked paths without panicking#330SegaraRai wants to merge 4 commits intovoidzero-dev:mainfrom
SegaraRai wants to merge 4 commits intovoidzero-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #325.
Windows file access tracking could panic when fspy observed a malformed path such as
foo/C:/bar. The path is initially accepted as relative, but lexical cleanup can turn it into a drive-prefixed path that no longer satisfiesRelativePathinvariants.RelativePath::clean()fallible instead of panicking when cleanup produces a non-relative pathTest plan
cargo test -p vite_path clean_malformed_drive_pathcargo test -p vite_task malformed_windows_drive_path_after_workspace_strip_is_ignoredcargo test -p vite_task_bin --test e2e_snapshots -- malformed-fspy-pathcargo check -p vite_path -p vite_task