test(cache): real-vite integration fixtures + playground#408
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c32f92dba9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Track the vite PR #22453 build until @voidzero-dev/vite-task-client is | ||
| # published to npm and the integration ships in a real vite release. Pinned | ||
| # to a commit-specific pkg.pr.new URL so bumps require updating this line. | ||
| vite: https://pkg.pr.new/vite@23ded7bb458062c028d7a52019133c9cfd51b105 |
There was a problem hiding this comment.
Add Vite to the test toolchain dependencies
This adds a catalog entry for Vite, but catalog entries do not install packages by themselves. The e2e harness resolves these new ignored fixtures by putting packages/tools/node_modules/.bin on PATH and symlinking packages/tools/node_modules/vite; since packages/tools/package.json still does not depend on vite, a clean pnpm install will not create that binary and vt run --cache build in this fixture fails before exercising the cache behavior. Please add vite: "catalog:" to the installed toolchain package (and update the lockfile) or otherwise make the fixture install it.
Useful? React with 👍 / 👎.
c32f92d to
aefe784
Compare
1ba9f54 to
d2b5429
Compare
3516a20 to
26d0762
Compare
d2b5429 to
3c2c82d
Compare
26d0762 to
56935f9
Compare
3c2c82d to
1d4b087
Compare
1d4b087 to
fa9255d
Compare
7a80c90 to
a1025cd
Compare
2858cb8 to
a587ced
Compare
12641eb to
e8f68dd
Compare
8c46da5 to
a5cc208
Compare
40d9dc4 to
d5d2cb5
Compare
a5cc208 to
4a3e31d
Compare
Adds the real-vite e2e coverage: `vite_build_cache` exercises runner-aware cache behaviour through `vite build` against the companion vite PR (NODE_ENV-change invalidation, `envPrefix`-driven tracked-env set, `dist/` write restoration on cache hit), and `vite_dev_disable_cache` verifies `disableCache()` short-circuits the dev server's run from the cache. Wires the rest of the consumer-side bits needed for vite (consumed via the `github:` spec for vite-task-client) to install cleanly: - Adds `vite: catalog:` to `packages/tools/package.json` so `pnpm install` materialises `packages/tools/node_modules/.bin/vite` for the harness's `link_tools_packages(stage, ["vite"])` symlink setup. - Pins root `packageManager` to `pnpm@10.33.4` matching the vite PR's pnpm, removing a per-install version switch that produced an outer-vs-inner lockfile-settings mismatch when vite consumed vite-task as a git dep. - Drops the root `prepare: husky` so pnpm's git-dep flow doesn't invoke `pnpm pack`, which had been producing a lockfile `resolution` entry without the `path:` field — pnpm then extracted the *entire* vite-task monorepo into `node_modules/@voidzero-dev/vite-task-client/` instead of the subpath. - Pins the vite catalog entry to a commit-specific `pkg.pr.new` URL so future bumps require updating this line. - Sets `blockExoticSubdeps: false` so pnpm 11 doesn't reject the transitive `github:` spec. Refreshes the playground to use the published vite + the runner- aware tools. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
d5d2cb5 to
e051931
Compare
4a3e31d to
9db3dd2
Compare
|
Superseded by restructured 2-PR stack:
|

Adds the real-vite e2e coverage:
vite_build_cacheexercisesrunner-aware cache behaviour through
vite buildagainst thecompanion vite PR (NODE_ENV-change invalidation,
envPrefix-driventracked-env set,
dist/write restoration on cache hit), andvite_dev_disable_cacheverifiesdisableCache()short-circuitsthe dev server's run from the cache.
Wires the rest of the consumer-side bits needed for vite (consumed
via the
github:spec for vite-task-client) to install cleanly:packageManagertopnpm@10.33.4matching the vitePR's pnpm, removing a per-install version switch that produced
an outer-vs-inner lockfile-settings mismatch when vite consumed
vite-task as a git dep.
prepare: huskyso pnpm's git-dep flow doesn'tinvoke
pnpm pack, which had been producing a lockfileresolutionentry without thepath:field — pnpm thenextracted the entire vite-task monorepo into
node_modules/@voidzero-dev/vite-task-client/instead of thesubpath.
pkg.pr.newURL so future bumps require updating this line.
blockExoticSubdeps: falseso pnpm 11 doesn't reject thetransitive
github:spec.Refreshes the playground to use the published vite + the runner-
aware tools.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com