Add php-parser v5 compatibility (^4.18 || ^5)

[Copilot]

• Utils.php – replace method_exists+wrong ->name fallback with ->toString() in ClassConstFetch path; use ->getParts() directly in ConstFetch path (works in both v4 and v5)
• BasePHPElement.php – replace implode('\\', $x->getParts()) with ->toString(); remove var_dump; guard getFQN fallback: $node->name instanceof Name ? $node->name->toString() : (string) $node->name
• PHPClass.php – replace getParts() with ->toString() (×2)
• PHPInterface.php – replace getParts() with ->toString()
• PHPEnum.php – replace getParts() with ->toString()
• PHPConst.php – replace getParts() with ->toString()
• ASTVisitor.php – use ->getParts()[0] (works in both v4 and v5)
• All 38 tests pass with php-parser v5.7.0

[voku]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for nikic/php-parser v5 by updating the composer constraints and implementing compatibility checks for deprecated or removed methods like getLine() and getParts(). While the transition to createForNewestSupportedVersion() and the line number handling are correct, there are critical issues in the fallback logic for Name nodes. Specifically, the code attempts to access the 'name' property which was removed in v5; these instances should be updated to use the 'parts' property to ensure compatibility across both versions.

[gemini-code-assist]

The fallback to $node->value->name->name for php-parser v5 is incorrect. The name property on PhpParser\Node\Name was removed in v5. For compatibility, you should use the public parts property instead.

                        $value = implode('\', method_exists($node->value->name, 'getParts') ? $node->value->name->getParts() : $node->value->name->parts);

[gemini-code-assist]

The fallback to [$node->name->name] for php-parser v5 is incorrect. The name property on PhpParser\Node\Name was removed in v5. You should use the public parts property instead, which is an array of name parts, just like the return value of getParts().

            $parts = method_exists($node->name, 'getParts') ? $node->name->getParts() : $node->name->parts;

[Copilot]

Pull request overview

This PR aims to make the library compatible with both nikic/php-parser v4.18+ and v5 by widening the Composer constraint and updating a few call sites that were removed in v5.

Changes:

• Widen nikic/php-parser requirement to ^4.18 || ^5.
• Switch parser instantiation to ParserFactory::createForNewestSupportedVersion().
• Add v5-safe fallbacks for Node::getLine() and Name::getParts() in a couple of locations.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
composer.json	Widens nikic/php-parser constraint to allow v5.
src/voku/SimplePhpParser/Parsers/PhpCodeParser.php	Uses createForNewestSupportedVersion() to avoid removed factory APIs in v5.
src/voku/SimplePhpParser/Model/BasePHPElement.php	Avoids Node::getLine() by preferring getStartLine().
src/voku/SimplePhpParser/Parsers/Helper/Utils.php	Guards Name::getParts() for v5 compatibility in getPhpParserValueFromNode().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

nikic/php-parser is now allowed at ^5, but the codebase still calls APIs removed in v5 (notably PhpParser\Node\Name::getParts()). I found remaining call sites in src/voku/SimplePhpParser/Model/BasePHPElement.php, Model/PHPClass.php, Model/PHPInterface.php, Model/PHPEnum.php, Model/PHPConst.php, and Parsers/Visitors/ASTVisitor.php. With php-parser v5 installed these will fatal at runtime, so the constraint change should be paired with updating those usages (e.g., prefer Name::toString() or a small compat helper that uses getParts() when available and falls back to ->name/toString()).

Suggested change

	"nikic/php-parser": "^4.18 || ^5"
	"nikic/php-parser": "^4.18"

[Copilot]

This file still uses Name::getParts() (e.g., in getConstantFQN() and getFQN()), which was removed in php-parser v5. Even though prepareNode() now avoids Node::getLine(), these remaining getParts() calls will still cause fatal errors under v5; please update them to use ->toString() or a compat wrapper (similar to the approach taken in Utils::getPhpParserValueFromNode()).

[Copilot]

getFQN() currently contains a var_dump($node->name); debug statement. This will emit output during normal library usage (breaking CLI output, JSON responses, etc.) and should be removed or replaced with a proper logger behind an explicit debug flag.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[voku]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

All the changes from that review thread were already applied in commits 836cd52 and 895f1be:

• BasePHPElement.php: replaced all implode('\\', $x->getParts()) with ->toString(), removed var_dump, fixed the getFQN() fallback to $node->name instanceof Name ? $node->name->toString() : (string) $node->name
• PHPClass.php, PHPInterface.php, PHPEnum.php, PHPConst.php: all getParts() patterns replaced with ->toString()
• Utils.php: ClassConstFetch path now uses ->toString() directly; two remaining getParts() calls are kept as-is since getParts() was not removed in v5

All 38 tests pass with php-parser v5.7.0.