Skip to content

Remove #[\ReturnTypeWillChange] in favor of proper return types #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
voku merged 2 commits into from
Apr 13, 2026
Merged

Remove #[\ReturnTypeWillChange] in favor of proper return types #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45c612
Initial plan
Copilot Apr 11, 2026
ee2b9be
fix: add proper return types to interface methods, remove #[ReturnTyp…
Copilot Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/Stringy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2509,14 +2509,11 @@ public function isWhitespace(): bool
* EXAMPLE: <code>
* </code>
*
* @noinspection ReturnTypeCanBeDeclaredInspection
*
* @psalm-mutation-free
*
* @return string The current value of the $str property
*/
#[\ReturnTypeWillChange]
public function jsonSerialize()
public function jsonSerialize(): mixed
{
return (string) $this;
}
Expand Down Expand Up @@ -3113,8 +3110,7 @@ public function offsetGet($offset): string
*
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetSet($offset, $value)
public function offsetSet($offset, $value): void
{
// Stringy is immutable, cannot directly set char
throw new \Exception('Stringy object is immutable, cannot modify char');
Expand All @@ -3134,8 +3130,7 @@ public function offsetSet($offset, $value)
*
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetUnset($offset)
public function offsetUnset($offset): void
{
// Don't allow directly modifying the string
throw new \Exception('Stringy object is immutable, cannot unset char');
Expand Down
Loading